-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-20.1: ui: fix Overview screen in OSS builds #64126
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the backport @koorosh
86ae98e
to
281af92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @koorosh)
281af92
to
153f65b
Compare
Closing due to issue with signing SLA. New PR will be created instead. |
The problem with SLA couldn't be solved with recreating another PR :( |
Previously, when using OSS builds (created with `make buildoss`), when you loading the DB Console in your browser, you'd get "Page Not Found". The route for the overview page was missing the leading '/'. This bug appears to have been introduced in 722c932. Release note (admin ui change): This fixes a bug where users of the OSS builds of CockroachDB would see "Page Not Found" when loading the Console.
153f65b
to
885f9f4
Compare
Backport 1/1 commits from #56591.
/cc @cockroachdb/release
Resolves #63376
Previously, when using OSS builds (created with
make buildoss
), whenyou loading the DB Console in your browser, you'd get "Page Not Found".
The route for the overview page was missing the leading '/'. This bug
appears to have been introduced in
722c932.
Release note (admin ui change): This fixes a bug where users of
the OSS builds of CockroachDB would see "Page Not Found" when loading
the Console.